CCP GingerDude wrote:Hey folks.
Being the guy writing this code, I think I should chime in a bit (disclaimer: I haven't read through the whole thread yet).
The corp hangars on ships code had to go. Sorry, but that's simply the reality of the matter. It's been broken since it was first put in the game and was made completely unfixable when fleet member access was added to the mix. And by broken I mean both design and implementation. Corp roles clashed and were inconsistent between usages, there was no way for the client to reliably know if it could access another players ship so it had to guess and handle errors (you can probably imagine how healthy and correct that was most of the time), you could put stuff in without knowing that you couldn't take it back and the list just kept growing. Every time someone fixed a bug in this code, at least two new bugs surfaced, usually within either POS corp hangar arrays or offices in stations as all 3 of them shared the same codebase. It. Had. To. Go.
So, taking as a given that we could no longer use the same code for the ships corp hangars as the other types, then the options really boil down to either a) rewrite the corp hangars on ships seperetaly, but keep the corp hangars concept, but not share the code with the other two types of corp hangars, or b) rethink the functionality. Having two almost identical corp-hangars implementations, except for a bunch of special cases, didn't ring particularly well with the engineer in me and having to construct some resemblance of sanity and to avoid code-duplication, either through inheritance or composition while doing it wasn't appealing either.
So, after asking around, both internally, via the CSM and within the player community where I know people, it was generally agreed that fleet hangars were the way to go.
I'm absolutely not dismissing any of your criticisms here, merely explaining why a change had to happen. We're putting significant effort these days to try to clean up some of the really bad code which has accumulated over the years that no-one dares touch anymore (this, crimewatch, POSes are getting some rethink Soon(tm)) because of the certain breakage said touching will cause.
That said, we can't please everybody at the same time, but we'll do our best to address your concerns wrt. the change in functionality here. We've already made a few changes to address stuff raised in this thread, but I'll leave it to CCP Habakuk and Grayscale to detail those. Keep watching this space....
Cheers.